This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Co #10719: Use into_account_truncating#4947
Merged
shawntabrizi merged 12 commits intomasterfrom May 17, 2022
Merged
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
shawntabrizi
approved these changes
May 16, 2022
kianenigma
approved these changes
May 17, 2022
|
Waiting for commit status. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_truncatingfunctions forAccountIdConversion.This is no logic change since the truncating already silently happened before. Now it is more explicit.
Companion for paritytech/substrate#10719
cumulus companion: paritytech/cumulus#1262